-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ebusd.service #502
Update ebusd.service #502
Conversation
eliminating the warning during booting the system: dmesg | grep ebus systemd[1]: /etc/systemd/system/ebusd.service:10: PIDFile= references a path below legacy directory /var/run/, updating /var/run/ebusd.pid → /run/ebusd.pid; please update the unit file accordingly.
@@ -7,7 +7,7 @@ ConditionPathExists=/var/log | |||
Type=forking | |||
Restart=always | |||
RestartSec=30 | |||
PIDFile=/var/run/ebusd.pid | |||
PIDFile=/run/ebusd.pid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
according to https://www.gnu.org/prep/standards/html_node/Directory-Variables.html it should be /var/run and not /run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
according to systemd document:
https://www.freedesktop.org/software/systemd/man/systemd.exec.html#RuntimeDirectory=
RuntimeDirectory= /run/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then it would have to be done differently for initd/systemd. plus you'd also have to tell ebusd about the changed location
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this you know better than, I just wanted to point it out that ev. path change is required.
thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even GNUInstallDirs of recent cmake still has LOCALSTATEDIR/run in it with LOCALSTATEDIR usually being /var, so I'll keep it until that changes
A better option for Systemd would be to run it in foreground mode, no need for PID files, etc |
eliminating the warning during booting the system:
dmesg | grep ebus
systemd[1]: /etc/systemd/system/ebusd.service:10: PIDFile= references a path below legacy directory /var/run/, updating /var/run/ebusd.pid → /run/ebusd.pid; please update the unit file accordingly.