Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch: Corrupt album art not displaying placeholder #43

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

johnnyshankman
Copy link
Owner

@johnnyshankman johnnyshankman commented Dec 20, 2024

This PR

See #42, bumps to 1.1.1

If the album art is set but the image it leads to is actually a corrupt JPG/PNG, we should display the same UX as if there was no image set.

Before

image

After

Screen.Recording.2024-12-19.at.10.19.10.PM.mov

@johnnyshankman johnnyshankman changed the title Patch: Corrupt album art not displaying placeholder Patch 1.1.1: Corrupt album art not displaying placeholder Dec 20, 2024
@johnnyshankman johnnyshankman changed the title Patch 1.1.1: Corrupt album art not displaying placeholder Patch: Corrupt album art not displaying placeholder Dec 20, 2024
@johnnyshankman johnnyshankman merged commit dbc0b60 into main Dec 20, 2024
1 check passed
@johnnyshankman johnnyshankman deleted the johnny/patch-corrupt-art branch December 20, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant