[Xcode 10][Carthage] Use new build system #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 18, 2018 11:43
Remove module.modulemap file from Copy Bundle Resources build phase since it causes Xcode 10’s new build system to crash
|
@torokzsolt #103 does the same thing and it was closed. Until that it has been determined that a version break is required, these changes will not be merged in. Feel free to use your fork though. |
|
@128keaton How does it break compatibility? Travis ran tests sucessfully with Xcode 9 |
|
Ah that’s my bad 🤗. I read it too fast. At this point I do not see a problem then.
… On Sep 18, 2018, at 10:49 AM, torokzsolt ***@***.***> wrote:
@128keaton How does it break compatibility? Travis ran tests sucessfully with Xcode 9
I did not removed DownView.bundle like #103.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
iwasrobbed
approved these changes
Sep 19, 2018
iwasrobbed
changed the title
Closed
|
Any chance we could get a new version with this fix in it now Xcode 10 is out? 😄 |
4 tasks
|
@Baza207 @Nickersoft @kimdv Pushed up v0.5.3 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating to Xcode 10 today I was unable to install Down (0.5.2) using Carthage.
The reason is that Xcode 10 uses the new build system by default which crashes when trying to build Down 0.5.2 (as reported in #91 and solved with PR #97 which sets the project to use the legacy build system)
This pull request removes the module.modulemap from Copy Bundle Resources build phase so the new build system doesn't crash anymore and sets the project to use it.