Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS Platform, Custom URL Scheme Handler, Polish Demos. #110

Merged
merged 14 commits into from
Nov 23, 2018
Merged

Fix macOS Platform, Custom URL Scheme Handler, Polish Demos. #110

merged 14 commits into from
Nov 23, 2018

Conversation

chriszielinski
Copy link
Contributor

  • DownView did not work on macOS 10.14. It appears loadHTMLString(_:baseURL:) does not allow local file access, unlike on the iOS platform. On macOS, it now copies the necessary files to a temporary directory and uses loadFileURL(_:allowingReadAccessTo:).
  • Added support for custom URL scheme handlers for macOS 10.13+ and iOS 11.0+. As well as a test case for it.
  • Added a macOS demo application and polished the iOS demo.

I'm unsure of the changelog formatting, so have not updated that.

@chriszielinski
Copy link
Contributor Author

Travis is attempting to test testCustomURLSchemeHandler() on macOS 10.12.* even though it's denoted @available(iOS 11.0, macOS 10.13, *). Not sure why... so I can either add an internal compiler directive to pass that case trivially, or update the osx_image Travis uses to a minimum of xcode9.3.

@iwasrobbed
Copy link
Collaborator

Hi @chriszielinski 👋

Thanks for all of these changes. Feel free to bump Travis's Xcode version to 9.4.1 and no worries about changelogs as that gets auto-generated.

I'll review these soon

Copy link
Collaborator

@iwasrobbed iwasrobbed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great overall, just a few changes to ensure things are speedy 👍

Thanks again!

Down-Example/Down-Example.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
Source/Views/DownView.swift Outdated Show resolved Hide resolved
Tests/DownViewTests.swift Show resolved Hide resolved
Down-Example/Down-Example/ViewController.swift Outdated Show resolved Hide resolved
Down-Example/macOS Demo/ViewController.swift Outdated Show resolved Hide resolved
Down-Example/Down-Example.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Nov 23, 2018

Coverage Status

Coverage decreased (-2.1%) to 90.625% when pulling 35f0277 on chriszielinski:master into d753044 on iwasrobbed:master.

@iwasrobbed
Copy link
Collaborator

Looks great, thanks again @chriszielinski !!

@iwasrobbed iwasrobbed merged commit 0c5cd04 into johnxnguyen:master Nov 23, 2018
@iwasrobbed
Copy link
Collaborator

Released as v0.6.1 👍 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants