-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix macOS Platform, Custom URL Scheme Handler, Polish Demos. #110
Conversation
…trailing closures.
Travis is attempting to test |
Hi @chriszielinski 👋 Thanks for all of these changes. Feel free to bump Travis's Xcode version to 9.4.1 and no worries about changelogs as that gets auto-generated. I'll review these soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great overall, just a few changes to ensure things are speedy 👍
Thanks again!
Looks great, thanks again @chriszielinski !! |
Released as v0.6.1 👍 🚀 |
DownView
did not work on macOS 10.14. It appearsloadHTMLString(_:baseURL:)
does not allow local file access, unlike on the iOS platform. On macOS, it now copies the necessary files to a temporary directory and usesloadFileURL(_:allowingReadAccessTo:)
.I'm unsure of the changelog formatting, so have not updated that.