Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compiler flag to suppress implicit conversion warnings #118

Merged
merged 1 commit into from
Nov 28, 2018

Conversation

phoney
Copy link
Contributor

@phoney phoney commented Nov 27, 2018

After recently importing the current version of cmark one compiler warning was fixed but five new ones appeared. I think this kind of whack-a-mole problem will continue as long as we're using cmark since it's C language and Down has different warnings enabled than the cmark developers do.

I've added a compiler flag to ignore the implicit integer conversion warnings. These are benign warnings and there's nothing really to be done about them in Down. When this warning is disabled Down compiles without warnings.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.625% when pulling 23076b4 on phoney:feature/fix-warnings into 1c90cbb on iwasrobbed:master.

Copy link
Collaborator

@iwasrobbed iwasrobbed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@iwasrobbed iwasrobbed merged commit d02f0f1 into johnxnguyen:master Nov 28, 2018
@iwasrobbed
Copy link
Collaborator

We'll see if anyone has issues with this and if we need to move it into a pod_target_xcconfig type specifier to scope it to just the pod and not the whole project. I know there's an inhibit_warnings! flag you can set in your Podfile as well but not sure if it works on this or not

@phoney phoney deleted the feature/fix-warnings branch March 21, 2019 20:22
@phoney phoney restored the feature/fix-warnings branch March 21, 2019 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants