-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump cmark to 0.29.0 #142
Bump cmark to 0.29.0 #142
Conversation
e2cbdc8
to
e6bf581
Compare
Hi @larryonoff 👋 Thanks for these changes Did you happen to follow the wiki to update these? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again, looks good 👍 I'll take care of adding the new option and updating docs
(Just an FYI: I took a quick diff of these changes against the cmark
repo since I'm hesitant to allow others to update cmark for security reasons)
* raw HTML is replaced by a placeholder HTML comment. Unsafe | ||
* links are replaced by empty strings. | ||
*/ | ||
#define CMARK_OPT_UNSAFE (1 << 17) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to add this to the DownOptions
and update the documentation for CMARK_OPT_SAFE
since this behavior changed in v0.29.0 (it used to pass through raw HTML and now it doesn't)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for mentioning and fixing this :)
Released as |
It looks that the guide is outdated. cmark has number of files that are used to generate the code. These generated files are in Down repo, e.g. |
@larryonoff @iwasrobbed - Yes, but those files didn't change when I updated the cmark version last time. Frankly, those files are an annoyance for us because we can't use them directly or in an automated way. If those files did change and you made updates due to that, the wiki could be updated to explain what to do in that case. |
Changelog: https://github.com/commonmark/cmark/releases/tag/0.29.0