[AST] Replace line separator with paragraph separator. #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwasrobbed
changed the title
iwasrobbed
requested changes
May 16, 2019
There was a problem hiding this comment.
Thanks @fgulan! This looks good to me at a high level, but I'd like @johnxnguyen to take a quick look.
Also, can you please fix the broken testAttributedStringVisitor test from these changes @fgulan? See https://travis-ci.org/iwasrobbed/Down/builds/533532109
johnxnguyen
approved these changes
May 17, 2019
|
Looks good to me! Thanks for this improvement. |
iwasrobbed
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a PR from CocoaMarkdown: indragiek/CocoaMarkdown#35 unicode line separator should be used for new lines inside paragraphs, while '\n' is reserved for separation between paragraphs.