Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swift Package Manager support #150

Merged
merged 5 commits into from
Jun 4, 2019
Merged

Add Swift Package Manager support #150

merged 5 commits into from
Jun 4, 2019

Conversation

aasimk2000
Copy link
Contributor

Adds SPM support. The main change this required was moving the cmark module map to the include directory. This is required by SPM for C languages.

@coveralls
Copy link

coveralls commented May 28, 2019

Coverage Status

Coverage remained the same at 93.381% when pulling 0a7235e on aasimk2000:spm into 80d8b2d on iwasrobbed:master.

@iwasrobbed
Copy link
Collaborator

Thanks for your help, @aasimk2000 ! I haven't used SPM before so I'll need to dig into this when I get a moment this week to make sure all is 👍 👍

@aasimk2000
Copy link
Contributor Author

Just want to add that looks like SPM is going to be supported across all Apple platforms in Xcode 11. https://developer.apple.com/videos/play/wwdc2019/408/

Copy link
Collaborator

@iwasrobbed iwasrobbed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my basic understanding of SPM

The only thing missing is the Xcode project file wasn't updated for moving the module map file. Mind ensuring that's reflected (e.g. delete it from the project, drag/drop it back in w/ no target membership)?

This was referenced Jun 3, 2019
@iwasrobbed
Copy link
Collaborator

Thanks again @aasimk2000 !

@iwasrobbed iwasrobbed merged commit d94b270 into johnxnguyen:master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants