Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public constructor #193

Closed
wants to merge 1 commit into from
Closed

Conversation

DanielOberg
Copy link

'Document' initializer is inaccessible due to 'internal' protection level

@codecov
Copy link

codecov bot commented Dec 7, 2019

Codecov Report

Merging #193 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #193   +/-   ##
=======================================
  Coverage   32.59%   32.59%           
=======================================
  Files          74       74           
  Lines        2362     2362           
=======================================
  Hits          770      770           
  Misses       1592     1592
Impacted Files Coverage Δ
Source/AST/Nodes/BaseNode.swift 92.3% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd1a3f6...b062042. Read the comment docs.

Copy link
Collaborator

@iwasrobbed iwasrobbed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DanielOberg 👋 When opening a PR, can you please explain why this change was necessary? e.g. what use case does Down not currently fulfill that this change will enable

@iwasrobbed
Copy link
Collaborator

Closing this out as I have not heard back. Feel free to reopen if you have a better PR description

@iwasrobbed iwasrobbed closed this Dec 18, 2019
@DanielOberg
Copy link
Author

Hi, sorry for the delay (busy with Christmas), @iwasrobbed!

So my use case is basically that I want to extract information from Markdown, edit it (add UUIDs for certain blocks iff they don't already exist) and then save it again as Markdown on quite big Markdown files.

Your wrapped AST:s helped a lot for that with this small change.

@iwasrobbed-ks
Copy link
Collaborator

@DanielOberg Please see the comment on #197 (comment) and let us know if you still need this or not.

@DanielOberg
Copy link
Author

@rob-keepsafe that solution also works perfectely! I'll revisit the issue after I've gone further along in the editing part of the AST code though.

Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants