Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add styling options for level 4 to 6 headings #207

Merged
merged 2 commits into from
Mar 19, 2020
Merged

Add styling options for level 4 to 6 headings #207

merged 2 commits into from
Mar 19, 2020

Conversation

mathebox
Copy link
Contributor

As of now, headings have the same style for levels 3 to 6.
This pull request adds customization points to style level 4 to 6 headings.
By default, level 4 to 6 headings will have the same style as a level 3 heading. So the current behavior will not be modified.

@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #207 into master will decrease coverage by 0.28%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   32.59%   32.31%   -0.29%     
==========================================
  Files          74       74              
  Lines        2362     2383      +21     
==========================================
  Hits          770      770              
- Misses       1592     1613      +21
Impacted Files Coverage Δ
Source/AST/Styling/Stylers/DownStyler.swift 0% <0%> (ø) ⬆️
...Styling/Attribute Collections/FontCollection.swift 0% <0%> (ø) ⬆️
Tests/Styler/StylerTestSuite.swift 0% <0%> (ø) ⬆️
...tyling/Attribute Collections/ColorCollection.swift 0% <0%> (ø) ⬆️
...tribute Collections/ParagraphStyleCollection.swift 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aada56...1e567c4. Read the comment docs.

Copy link
Collaborator

@iwasrobbed-ks iwasrobbed-ks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mathebox 👍

@iwasrobbed iwasrobbed merged commit de6c587 into johnxnguyen:master Mar 19, 2020
Juraldinio added a commit to Juraldinio/Down that referenced this pull request Mar 23, 2020
Add styling options for level 4 to 6 headings (johnxnguyen#207)
regennz pushed a commit to regennz/Down that referenced this pull request Apr 14, 2020
* Add styling options for level 4 to 6 headings

* Adjust colors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants