Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tightness property to List node #215

Merged
merged 6 commits into from
Jun 12, 2020
Merged

Conversation

johnxnguyen
Copy link
Owner

@johnxnguyen johnxnguyen commented Jun 10, 2020

What's in this PR?

This PR adds the isTight property to the List node. List tightness is a hint to a renderer whether it should apply extra spacing between list items or not.

Closes #214

Note

Usage of this property to adjust the list item spacing will be addressed in a separate PR.

Copy link
Collaborator

@iwasrobbed-ks iwasrobbed-ks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks 👍 just needs a test update before merging please 🙏

@johnxnguyen
Copy link
Owner Author

@rob-keepsafe yep, just having issues building the test target on my machine, will try to fix it as soon as I have some free time.

@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #215 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #215   +/-   ##
=======================================
  Coverage   68.63%   68.63%           
=======================================
  Files          74       74           
  Lines        2047     2047           
=======================================
  Hits         1405     1405           
  Misses        642      642           
Impacted Files Coverage Δ
Source/AST/Nodes/List.swift 88.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c389ca6...58efbe6. Read the comment docs.

@iwasrobbed-ks iwasrobbed-ks merged commit 6638a36 into master Jun 12, 2020
@iwasrobbed-ks iwasrobbed-ks deleted the feature/list-tightness branch June 12, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Line breaks between list items are not parsed correctly
4 participants