Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable analysis of cmark source code #31

Merged

Conversation

tonyarnold
Copy link
Collaborator

This PR is in response to #26. Normally, I'd look at fixing the issues upstream, but in this case I'm not sure I have time or the inclination (or that they'd even be considered issues upstream in cmark).

Unless there is intent to fix the issues cmark, the analysis issues therein should be ignored - I am seeing quite a number of analysis issues being raised on my CI servers from this.

@tonyarnold tonyarnold self-assigned this May 25, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.623% when pulling 507838b on tonyarnold:disable-analysis-for-cmark into 43241e5 on iwasrobbed:master.

@iwasrobbed
Copy link
Collaborator

Looks good @tonyarnold ! Thanks for this

@iwasrobbed iwasrobbed merged commit 142e930 into johnxnguyen:master May 25, 2017
@iwasrobbed
Copy link
Collaborator

Just as an aside, I don't think this fixes #26 by the way, since $ pod spec lint Down.podspec still gives warnings. I don't have much time to look into this for now unfortunately

@tonyarnold tonyarnold deleted the disable-analysis-for-cmark branch May 26, 2017 00:08
@tonyarnold
Copy link
Collaborator Author

Right, yes, on a second reading I can see that it developed into being specific to CocoaPods - sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants