Fix Carthage builds #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the very quick PR @tonyarnold 💯 ! As I don't use Carthage, I'd like someone else to review / validate this. Maybe @georgemp or @kengruven could from the #70 issue |
|
I'm not on Xcode 9 yet, but I did backport the 6 lines onto a branch of v0.3.5, and it builds just fine there, so it looks good to me. |
|
Perfect, thank you for doing that @kengruven and once again thanks @tonyarnold I'll go ahead and merge for now and @georgemp can report back any issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70.
The
SDKROOThad been manually set toiphoneos- this will be inferred during build for the appropriate target platform.