Roll up cmark's COPYING sections into the top-level LICENSE file #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make it easier for integrators to do the right thing, when distributing binaries containing Down. The cmark COPYING file already includes all of the licenses for its included sub-projects.
|
Looks good and makes sense, thanks @kengruven ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier for integrators to do the right thing, when distributing binaries containing Down.
Right now, Down.framework has two license files: the top-level "LICENSE", and "Source/cmark/COPYING". Any binary distribution will need to include both, but it's easy to miss the latter.
Usually, I find that projects that include other projects will combine the license files. For example, cmark itself includes 7 sub-projects (houdini, buffer.c, utf8.c, etc), and its license has separate sections for each, in the same file, so you can just include cmark's "COPYING" file and catch everything.