Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Consistent use of walletName vs walletFileName #671

Merged
merged 18 commits into from
Oct 8, 2023
Merged

refactor: Consistent use of walletName vs walletFileName #671

merged 18 commits into from
Oct 8, 2023

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Oct 4, 2023 •
edited
Loading

Resolves #640.

Blocked by #665 (needs rebase afterwards).

This is a refactoring PR - no new features, no functionality changes.

While trying to consistently use displayName and walletFileName, it was easier/necessary to also migrate all components to typescript. So this turned from resolving #640 into a "jsx to tsx" PR rather quickly. Now, only one non-typescript component is left (ShareButton).

  • refactor: Wallets component from jsx to tsx
  • refactor: Settings component from jsx to tsx
  • refactor: ScheduleProgress component from jsx to tsx
  • refactor: Onboarding component from jsx to tsx
  • refactor: Earn component from jsx to tsx
  • refactor: Receive component from jsx to tsx
  • refactor: CreateWallet component from jsx to tsx
  • refactor: BitcoinQR component from jsx to tsx

@theborakompanioni theborakompanioni added tech dept Removes some technical debt refactoring Code refactoring without functional changes labels Oct 4, 2023
@theborakompanioni theborakompanioni self-assigned this Oct 4, 2023
@theborakompanioni theborakompanioni added the blocked Merging this pull request is blocked until another issue is resolved label Oct 4, 2023
@theborakompanioni theborakompanioni force-pushed the refactor/wallet-display-name branch from a5cc4ca to 58833ca Compare October 6, 2023 08:27
@theborakompanioni theborakompanioni marked this pull request as ready for review October 8, 2023 13:09
@theborakompanioni theborakompanioni marked this pull request as draft October 8, 2023 13:09
@theborakompanioni
dev(auth): add Single- and RefreshTokenContext types
ca21455
@theborakompanioni
dev(auth): save auth context to session
ee24a09
@theborakompanioni
dev(auth): refresh token periodically
c273704
@theborakompanioni
dev(auth): maintain CurrentWallet reference when renewing auth token
e6880bf
@theborakompanioni
dev(auth): add distinct method to parse auth props
2c9a15f
@theborakompanioni
refactor: consistent use of displayName vs walletFileName
8a0fee6
@theborakompanioni
refactor: Settings component from jsx to tsx
94f0130
@theborakompanioni
fix: pass wallet props properly
5fe58d9
@theborakompanioni
refactor: Wallets component from jsx to tsx
fab1500
@theborakompanioni
refactor: Onboarding component from jsx to tsx
4e7ff0e
@theborakompanioni
refactor: ScheduleProgress component from jsx to tsx
3eedba6
@theborakompanioni
chore(i18n): consistent use of global.errors.reason_unknown
6235584
@theborakompanioni
refactor: CreateWallet component from jsx to tsx
0c4287b
@theborakompanioni
refactor: BitcoinQR from jsx to tsx
79e2efd
@theborakompanioni
refactor: Receive component from jsx to tsx
1762da3
@theborakompanioni
refactor: Earn component from jsx to tsx
9834c73
@theborakompanioni
dev(regtest): switch to python:3.11-slim-bookworm as base image
2c56940 
see JoinMarket-Org/joinmarket-clientserver#1484 (comment)
@theborakompanioni theborakompanioni force-pushed the refactor/wallet-display-name branch from ef884fa to f87ec04 Compare October 8, 2023 13:23
@theborakompanioni theborakompanioni marked this pull request as ready for review October 8, 2023 13:28
@theborakompanioni theborakompanioni force-pushed the refactor/wallet-display-name branch from f87ec04 to 841e120 Compare October 8, 2023 13:37
@theborakompanioni theborakompanioni removed the blocked Merging this pull request is blocked until another issue is resolved label Oct 8, 2023
@theborakompanioni theborakompanioni merged commit 11ee5b4 into master Oct 8, 2023
3 checks passed
@theborakompanioni theborakompanioni deleted the refactor/wallet-display-name branch October 8, 2023 13:44
editwentyone
editwentyone reviewed Oct 10, 2023
View reviewed changes
Copy link

@editwentyone editwentyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@editwentyone editwentyone editwentyone left review comments

Assignees

@theborakompanioni theborakompanioni

Labels
refactoring Code refactoring without functional changes tech dept Removes some technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: Consistent use of walletName vs walletFileName
2 participants
@theborakompanioni @editwentyone