Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zh-Hant #176

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Update zh-Hant #176

merged 2 commits into from
Jan 2, 2025

Conversation

lancelot-moon
Copy link
Contributor

Fix and update.

Fix and update.
@lancelot-moon lancelot-moon requested a review from jojost1 as a code owner January 1, 2025 15:37
@lancelot-moon
Copy link
Contributor Author

lancelot-moon commented Jan 1, 2025

@jojost1
// MARK: v4.8
"disable_for" = "Disable for...";

For what? Time or something?
A screenshot?
If it's time, I need to fix the translation.
Thanks.

@jojost1
Copy link
Owner

jojost1 commented Jan 1, 2025

@lancelot-moon

  • for the string "protection_disabled_for_%@" it's used like this: "protection_disabled_for_\(Text(disabledUntil, style: .timer))" which is translated to "Disabled for 09:50" for example (disabled for 9min and 50sec).
  • "disable_for" is used in the confirmation dialog on Apple Watch when pressing the 'disable for x time' button. So the context is indeed time, as in: an alert with title "Disable for..." and options "5 minutes", "1 hour", etc.

I'll wait with merging this PR in until your changes!

@jojost1 jojost1 mentioned this pull request Jan 1, 2025
@lancelot-moon
Copy link
Contributor Author

@jojost1

Fixed one string here.
a39790d

Thanks.

Copy link
Owner

@jojost1 jojost1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@jojost1 jojost1 merged commit dd22ffe into jojost1:main Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants