Skip to content

Commit

Permalink
fix: move installation dependencies to setup.py
Browse files Browse the repository at this point in the history
They were previously in pyproject.toml under buil-system, which was not the right way to do this.
  • Loading branch information
jolars committed Nov 29, 2023
1 parent ac5e3ef commit 2506902
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
python -m pip install pybind11 setuptools numpy
python -m pip install pybind11 setuptools
- name: Install
run: python -m pip install .
Expand Down
3 changes: 0 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,5 @@ requires = [
"setuptools>=42",
"wheel",
"pybind11>=2.6.0",
"scipy",
"scikit-learn",
"numpy"
]
build-backend = "setuptools.build_meta"
3 changes: 3 additions & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
exec(fp.read(), version)
__version__ = version["__version__"]

install_requires = ["numpy", "scipy", "scikit-learn"]

ext_modules = [
Pybind11Extension(
"_sortedl1",
Expand All @@ -30,6 +32,7 @@
url="https://github.com/jolars/sortedl1",
description="Sorted L-One Penalized Estimation (SLOPE)",
long_description="",
install_requires=install_requires,
ext_modules=ext_modules,
cmdclass={"build_ext": build_ext},
zip_safe=False,
Expand Down

0 comments on commit 2506902

Please sign in to comment.