Fix progress reporting for files larger than Integer.MAX_VALUE (2.14 GB) on Android #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding File Transforms
…pendency added missing base64 dependency
Fix content length to be capped at Integer.MAX_VALUE for downloads
The assigned `task` variable is not available on the cancel method. This moves the assignment outside the promise scope and allows it to be correctly called.
this call was setting `transform` to `true` and missing out the required `append` boolean value. Because of this uploads were sometimes failing. This changes the call to be `transform: false` and `append: true`.
append file - add in missing parameter
🐛 Fix Task Scoping for Fetch Cancellation
… method. This method is called on demand when we are ready to stream the contents into the buffered sink
Fix type declaration for `close()` in interface `ReactNativeBlobUtilWriteStream`
A fix for "unexpected end of stream error" issue #137
Recently realized this permission got added to my project after pulling in this as a dependency, which was surprising since I saw the alert on F-Droid. This seems like a permission that should be added by the app developer if needed, not something intrinsically required/added by this library.
Remove CHECK_LICENSE permission
Remove redundant iOS 7 polyfill
Enable reporting of progress from Android DownloadManager
Merge remote-tracking branch 'origin/feature/trustmanager_removal' into develop
Merge remote-tracking branch 'origin/develop'
* [BREAKING] For the trusty option a custom trust manager has to be defined and injected (see Reamde for more details). This change has been made due to app rejections in the google play store. Security checks might have flagged the trust manager implementation even though it never was used * Enable reporting of progress from Android DownloadManager * Remove redundant iOS 7 polyfill * Remove CHECK_LICENSE permission * A fix for "unexpected end of stream error" issue Fixes #137 * Fix type declaration for `close()` in interface `ReactNativeBlobUtilWriteStream`
✨ XMLHttpRequest: Handle FormData body
modify Self-Signed SSL Server
Update README.md
use version as tag for podspec
Fix out of memory issues hashing large files on iOS
Provided download background support to ios devices
Fixed integer overflow issue in slice function for android
fix: pathForAppGroup typescript error
Ensuring ascii file reads do not fall through to else case for UTF-8 reading
This issue is due to: react-native-community/discussions-and-proposals#671 And will reintroduce a warning for old libraries
…ile in app specific directories #299
Changed slice method type
Remove deprecated API's from react-native-blob-util
- 注释掉了 ReactNativeBlobUtilReq.java 中的几个 RNLog.w() 调用 - 这些日志输出主要用于调试，现在已不再需要
refactor(android): 移除不必要的日志输出
fix(Session): remove() method doesn't remove path from list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you attempt to download a file that is larger than ~2 GB on Android you won't receive any progress updates. The fix in this case is simply hard coding a max contentLength so that at least delta updates will come through. This was confirmed to work experimentally and is admittedly a small edge case.