Prepare for syn v2 #578
Merged
Prepare for syn v2 #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 18, 2023
Codecov Report
@@ Coverage Diff @@
## master #578 +/- ##
=======================================
Coverage 63.56% 63.56%
=======================================
Files 35 35
Lines 2072 2072
=======================================
Hits 1317 1317
Misses 755 755
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Update serde to a version using syn v2. Update cxx and thiserror in the lock file to versions using syn v2. Update darling to v20
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 27, 2023
578: Prepare for syn v2 r=jonasbb a=jonasbb Update darling to v0.20 and syn to v2, require serde v1.0.157 (first using syn v2). This moves all direct dependencies to crates using syn v2. syn v2 has problems with the `#[serde_as(as = "..")]` style of attributes, since `as` is a keyword and keywords are not allowed in meta attributes. Instead pre-process the token stream to replace all `as` with `r#as` which can be parsed. Bump thiserror and cxx in the lock file. Not all crates are using syn v2 yet. Co-authored-by: Jonas Bushart <[email protected]>
|
Build failed: |
|
bors r+ |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update darling to v0.20 and syn to v2, require serde v1.0.157 (first using syn v2).
This moves all direct dependencies to crates using syn v2.
syn v2 has problems with the
#[serde_as(as = "..")]style of attributes, sinceasis a keyword and keywords are not allowed in meta attributes. Instead pre-process the token stream to replace allaswithr#aswhich can be parsed.Bump thiserror and cxx in the lock file.
Not all crates are using syn v2 yet.