Allow external crates to add their own JsonSchema
impls for custom SerializeAs
and DeserializeAs
types
#679
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is written on top of #676.
Implementing
JsonSchema
directly onserde_with::Schema<T, TA>
works fine when withinserde_with
. Once you are outside the crate, however, the orphan rules prevent you from adding impls of the formWe would like users to be able to make that impl (or something equivalent) so we need to find a way to make it work. We make this work by adding a new layer of trait indirection.
This PR introduces a new
JsonSchemaAs<T>
trait, adds a blanketand then changes all the existing impls to be for
JsonSchemaAs<T>
instead of onSchema<T, TA>
.Now, when a user wants to add json schema support for their own type they can implement
JsonSchemaAs<T>
for their custom type and the orphan rules will allow it.As a bonus, this seems to have made the extraordinarily confusing "reached recursion limit" errors that I have been encountering disappear. Which is nice.