Type correctness fixes #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some attempts to print 64-bit integers with
%d. I decided to narrow the type ofMicroProfileLogGetTyperather than change the format string, since a 64-bit integer for 2 bit flags is way too overkill. We should also consider narrowing other types likeMicroProfileLogGetTimerIndexwhich also uses a 64-bit integer even thoughMicroProfileGetTimerIndexreturns a 16-bit integer.Beyond this there are many more type fixes possible, since there's lots of attempts to print unsigned types as signed integers. Shall I address those in this PR as well or should we keep that separate? Also, do you want to use
%PRIu64or%lld? I've seen both usages, we don't really need to use the former since we don't rely on the libcsprintf.Fixes issue #86.