Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color user-defined async functions correctly for Rust coloring #213

Merged
merged 1 commit into from
May 26, 2021

Conversation

dmarriner
Copy link

The current Rust coloring is a little confusing because it colors desugared user-defined async functions in the same color as system functions. This change will cause the Rust coloring to use the user coloring instead of the system coloring for those functions.

Before:

before

After:

after

@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #213 (0291e6b) into master (98bc13d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
+ Coverage   89.63%   89.64%   +0.01%     
==========================================
  Files          17       17              
  Lines        2353     2357       +4     
==========================================
+ Hits         2109     2113       +4     
  Misses        244      244              
Impacted Files Coverage Δ
src/flamegraph/color/palettes.rs 99.39% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98bc13d...0291e6b. Read the comment docs.

Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!

@jonhoo jonhoo merged commit 7ecd6e1 into jonhoo:master May 26, 2021
@jonhoo
Copy link
Owner

jonhoo commented May 26, 2021

Released in 0.10.6 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants