-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: export type information for node16 module resolution #28
base: master
Are you sure you want to change the base?
fix: export type information for node16 module resolution #28
Conversation
6db0155
to
c00f8d4
Compare
c00f8d4
to
1cc2106
Compare
I was about to create a PR for this, but @RebeccaStevens has done a great job here already. |
@jonschlinkert @TrySound Is there any chance to move this forward? This blocks people using TS ESM with is-plain-object. |
@jonschlinkert is this library unmaintained? |
Just ran into this issue when migrating a codebase to Anyone know of an alternative NPM package that you can use to resolve this issue? Otherwise I'll just fork this one, fix the issue and publish to NPM. |
https://github.com/sindresorhus/is-plain-obj works well with TypeScript ESM. |
Summary: - Rewrite TypeScript definitions to use ESM syntax, avoiding the specific syntax like `namespace`. - Update `tsconfig.json` for ESM and Node.js 18. - Remove no longer needed `test.d.ts`. - Add a patch for the `is-plain-object` package to avoid type-check errors. See also: - https://www.typescriptlang.org/tsconfig - https://devblogs.microsoft.com/typescript/announcing-typescript-4-7/#package-json-exports-imports-and-self-referencing - jonschlinkert/is-plain-object#28
Summary: - Rewrite TypeScript definitions to use ESM syntax, avoiding the specific syntax like `namespace`. - Update `tsconfig.json` for ESM and Node.js 18. - Remove no longer needed `test.d.ts`. - Add a patch for the `is-plain-object` package to avoid type-check errors. See also: - https://www.typescriptlang.org/tsconfig - https://devblogs.microsoft.com/typescript/announcing-typescript-4-7/#package-json-exports-imports-and-self-referencing - jonschlinkert/is-plain-object#28
See TS 4.7-rc Release Notes for details.