Adding Test for Deleting Category #103

puneet0191 · 2015-10-29T09:49:11Z

No description provided.

therunnergit · 2015-10-29T13:23:12Z

@test works fine.

puneet0191 · 2015-10-29T13:26:09Z

Thanks, I will refactor this by making use of Step Object. Need some time

puneet0191 · 2015-10-29T14:34:39Z

The build will fail since this PR depends on joomla-projects/joomla-browser#71

therunnergit · 2015-10-29T15:28:36Z

@test tested again, still working fine (after "composer install").

javigomez · 2015-10-30T08:24:33Z

tests/_support/Step/Acceptance/category.php

+	 *
+	 * @return void
+	 */
+	public function deleteCategory($categoryName)


Great work!

Just one comment. Could this method be renamed to "trashCategory" and keep the deleteCategory for when we completely delete the category from the database.

puneet0191 · 2015-10-30T08:34:47Z

I have updated the function name! thanks for the feedback!

javigomez · 2015-10-30T08:43:22Z

tests/acceptance/administrator/AdministratorCategoriesCest.php


 		$I->amGoingTo('Try to unpublish a weblink category');
-		$I->click(['xpath' => "//button[@onclick=\"if (document.adminForm.boxchecked.value==0){alert('Please first make a selection from the list.');}else{ Joomla.submitbutton('categories.unpublish')}\"]"]);
+		$I->clickToolbarButton('unpublish');


nice 👍

related to joomla-projects/joomla-browser#71

javigomez · 2015-10-30T08:57:24Z

@test

Worked:

vendor/bin/codecept run --steps --debug tests/acceptance/administrator/AdministratorCategoriesCest.php
Codeception PHP Testing Framework v2.1.3
Powered by PHPUnit 4.8.16 by Sebastian Bergmann and contributors.

Acceptance Tests (4) -----------------------------------------------------------
Modules: JoomlaBrowser, AcceptanceHelper
--------------------------------------------------------------------------------
Test Category  (AdministratorCategoriesCest::administratorCreateCategory)
Scenario:
* As an Administrator
* I do administrator login 

  I open Joomla Administrator Login Page
  [GET] http://joomla.box/repos/weblinks/tests/joomla-cms3/administrator/index.php
  Fill Username Text Field
  Fill Password Text Field
  I click Login button
  I wait to see Administrator Control Panel
* I am going to Navigate to Categories page in /administrator/ and create a Category
* As an Administrator
* I am on page "administrator/index.php?option=com_categories&extension=com_weblinks"
  [GET] http://joomla.box/repos/weblinks/tests/joomla-cms3/administrator/index.php?option=com_categories&extension=com_weblinks
* I wait for text "Weblinks: Categories","30",{"css":"h1"}
* I expect to see categories page
* I check for php notices or warnings 
* I am going to try to save a category with a filled title
* I click toolbar button "New"
* I wait for text "Weblinks: New Category","30",{"css":"h1"}
* I fill field {"id":"jform_title"},"automated testing19"
* I click toolbar button "Save & Close"
* I expect to see a success message after saving the category
* I see "Category successfully saved",{"id":"system-message-container"}
* I am going to Delete the Category which was created
* I am on page "administrator/index.php?option=com_categories&extension=com_weblinks"
  [GET] http://joomla.box/repos/weblinks/tests/joomla-cms3/administrator/index.php?option=com_categories&extension=com_weblinks
* I wait for text "Weblinks: Categories","30",{"css":"h1"}
* I search for item "automated testing19"
  Searching for automated testing19
* I am going to Select the weblink result
* I check all results 
  Selecting Checkall button
* I click toolbar button "Trash"
* I see "category successfully trashed.",{"id":"system-message-container"}
 PASSED 

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Test Category creation in /administrator/ without ti (AdministratorCategoriesCest::administratorCreateCategoryWithoutTitleFails)
Scenario:
* As an Administrator
* I do administrator login 

  I open Joomla Administrator Login Page
  [GET] http://joomla.box/repos/weblinks/tests/joomla-cms3/administrator/index.php
  Fill Username Text Field
  Fill Password Text Field
  I click Login button
  I wait to see Administrator Control Panel
* I am going to Navigate to Categories page in /administrator/
* I am on page "administrator/index.php?option=com_categories&extension=com_weblinks"
  [GET] http://joomla.box/repos/weblinks/tests/joomla-cms3/administrator/index.php?option=com_categories&extension=com_weblinks
* I wait for text "Weblinks: Categories","30",{"css":"h1"}
* I expect to see categories page
* I am going to try to save a category with empty title and it should fail
* I click {"xpath":"//button[@onclick="Joomla.submitbutton('category.add')"]"}
* I wait for text "Weblinks: New Category","30",{"css":"h1"}
* I click {"xpath":"//button[@onclick="Joomla.submitbutton('category.apply')"]"}
* I expect to see an error when trying to save a category without title
* I see "Invalid field:  Title",{"id":"system-message-container"}
 PASSED 

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Test Category (AdministratorCategoriesCest::administratorPublishCategory)
Scenario:
* As an Administrator
* I do administrator login 

  I open Joomla Administrator Login Page
  [GET] http://joomla.box/repos/weblinks/tests/joomla-cms3/administrator/index.php
  Fill Username Text Field
  Fill Password Text Field
  I click Login button
  I wait to see Administrator Control Panel
* I am going to Navigate to Categories page in /administrator/ and create a new Category
* As an Administrator
* I am on page "administrator/index.php?option=com_categories&extension=com_weblinks"
  [GET] http://joomla.box/repos/weblinks/tests/joomla-cms3/administrator/index.php?option=com_categories&extension=com_weblinks
* I wait for text "Weblinks: Categories","30",{"css":"h1"}
* I expect to see categories page
* I check for php notices or warnings 
* I am going to try to save a category with a filled title
* I click toolbar button "New"
* I wait for text "Weblinks: New Category","30",{"css":"h1"}
* I fill field {"id":"jform_title"},"automated testing pub88"
* I click toolbar button "Save & Close"
* I expect to see a success message after saving the category
* I see "Category successfully saved",{"id":"system-message-container"}
* I search for item "automated testing pub88"
  Searching for automated testing pub88
* I wait for text "Weblinks: Categories","30",{"css":"h1"}
* I check all results 
  Selecting Checkall button
* I am going to try to publish a weblink category
* I click toolbar button "publish"
* I wait for text "Weblinks: Categories","30",{"css":"h1"}
* I expect to see a success message after publishing the category
* I see "1 category successfully published.",{"id":"system-message-container"}
* I am going to Delete the Category which was created
* I am on page "administrator/index.php?option=com_categories&extension=com_weblinks"
  [GET] http://joomla.box/repos/weblinks/tests/joomla-cms3/administrator/index.php?option=com_categories&extension=com_weblinks
* I wait for text "Weblinks: Categories","30",{"css":"h1"}
* I search for item "automated testing pub88"
  Searching for automated testing pub88
* I am going to Select the weblink result
* I check all results 
  Selecting Checkall button
* I click toolbar button "Trash"
* I see "category successfully trashed.",{"id":"system-message-container"}
 PASSED 

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Test Catego (AdministratorCategoriesCest::administratorUnpublishCategory)
Scenario:
* As an Administrator
* I do administrator login 

  I open Joomla Administrator Login Page
  [GET] http://joomla.box/repos/weblinks/tests/joomla-cms3/administrator/index.php
  Fill Username Text Field
  Fill Password Text Field
  I click Login button
  I wait to see Administrator Control Panel
* I am going to Navigate to Categories page in /administrator/
* As an Administrator
* I am on page "administrator/index.php?option=com_categories&extension=com_weblinks"
  [GET] http://joomla.box/repos/weblinks/tests/joomla-cms3/administrator/index.php?option=com_categories&extension=com_weblinks
* I wait for text "Weblinks: Categories","30",{"css":"h1"}
* I expect to see categories page
* I check for php notices or warnings 
* I am going to try to save a category with a filled title
* I click toolbar button "New"
* I wait for text "Weblinks: New Category","30",{"css":"h1"}
* I fill field {"id":"jform_title"},"automated testing unpub16"
* I click toolbar button "Save & Close"
* I expect to see a success message after saving the category
* I see "Category successfully saved",{"id":"system-message-container"}
* I search for item "automated testing unpub16"
  Searching for automated testing unpub16
* I wait for text "Weblinks: Categories","30",{"css":"h1"}
* I check all results 
  Selecting Checkall button
* I am going to try to publish a weblink category
* I click toolbar button "publish"
* I wait for text "Weblinks: Categories","30",{"css":"h1"}
* I expect to see a success message after publishing the category
* I see "1 category successfully published.",{"id":"system-message-container"}
* I wait for text "Weblinks: Categories","30",{"css":"h1"}
* I check all results 
  Selecting Checkall button
* I am going to Try to unpublish a weblink category
* I click toolbar button "unpublish"
* I wait for text "Weblinks: Categories","30",{"css":"h1"}
* I expect to See a success message after unpublishing the category
* I see "1 category successfully unpublished",{"id":"system-message-container"}
* I am going to Delete the Category which was created
* I am on page "administrator/index.php?option=com_categories&extension=com_weblinks"
  [GET] http://joomla.box/repos/weblinks/tests/joomla-cms3/administrator/index.php?option=com_categories&extension=com_weblinks
* I wait for text "Weblinks: Categories","30",{"css":"h1"}
* I search for item "automated testing unpub16"
  Searching for automated testing unpub16
* I am going to Select the weblink result
* I check all results 
  Selecting Checkall button
* I click toolbar button "Trash"
* I see "category successfully trashed.",{"id":"system-message-container"}
 PASSED

Kubik-Rubik · 2015-10-30T10:10:52Z

Thank you @puneet0191! Merged with d42948b

puneet0191 · 2015-10-30T10:11:41Z

Thanks @Kubik-Rubik 👌

puneet0191 added 2 commits October 29, 2015 15:17

Adding test to Test Category Deletion

afd36c1

Updating Composer Lock File

8f34c7c

puneet0191 assigned puneet0191 and javigomez and unassigned puneet0191 Oct 29, 2015

zero-24 added the system tests / QA label Oct 29, 2015

zero-24 added this to the 3.4.2 milestone Oct 29, 2015

puneet0191 added 2 commits October 29, 2015 20:02

Adding a Category Step Class

9b49ad6

Updating Administrator Categories Cest Test File, Refactoring Code

c966384

Updating Composer Lock file for Joomla! Browser

fc4567f

puneet0191 mentioned this pull request Oct 30, 2015

Adding test to check if category got archived #105

Merged

javigomez reviewed Oct 30, 2015
View reviewed changes

puneet0191 added 2 commits October 30, 2015 14:03

Updating Function Name

cd389d4

Updating the calls

9ef36f1

javigomez reviewed Oct 30, 2015
View reviewed changes

javigomez added the RTC label Oct 30, 2015

javigomez assigned Kubik-Rubik and unassigned javigomez Oct 30, 2015

puneet0191 closed this in d42948b Oct 30, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Test for Deleting Category #103

Adding Test for Deleting Category #103

puneet0191 commented Oct 29, 2015

therunnergit commented Oct 29, 2015

puneet0191 commented Oct 29, 2015

puneet0191 commented Oct 29, 2015

therunnergit commented Oct 29, 2015

javigomez Oct 30, 2015

puneet0191 commented Oct 30, 2015

javigomez Oct 30, 2015

javigomez commented Oct 30, 2015

Kubik-Rubik commented Oct 30, 2015

puneet0191 commented Oct 30, 2015

Adding Test for Deleting Category #103

Adding Test for Deleting Category #103

Conversation

puneet0191 commented Oct 29, 2015

therunnergit commented Oct 29, 2015

puneet0191 commented Oct 29, 2015

puneet0191 commented Oct 29, 2015

therunnergit commented Oct 29, 2015

javigomez Oct 30, 2015

Choose a reason for hiding this comment

puneet0191 commented Oct 30, 2015

javigomez Oct 30, 2015

Choose a reason for hiding this comment

javigomez commented Oct 30, 2015

Kubik-Rubik commented Oct 30, 2015

puneet0191 commented Oct 30, 2015