Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing JGrid in some backend components #23

Closed
wants to merge 1 commit into from
Closed

Implementing JGrid in some backend components #23

wants to merge 1 commit into from

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Nov 30, 2011

This pull request implements JGrid in some backend components.

This touches the users view of com_users and the categories view of com_categories. These changes are 100% backwards compatible and will not influence existing templates. For future templates, it will be easier to modify the existing views and less code will be necessary for this.

This reduces the amount of code necessary for generating the backend tables and simplifies the hathor overrides.

If the platform project accepts a change to JView, the tables could also be modified by a plugin, maybe removing the need for overrides in quite a few cases.

@infograf768
Copy link
Member

Please post your patch in the tracker. This is where we test and comment for now.

@dextercowley
Copy link
Contributor

Hannes, I don't see an issue for this in the Feature Tracker on Jcode. Can
you please add one there so people can test and comment? Thanks. Mark

On Wed, Nov 30, 2011 at 3:22 AM, Hannes Papenberg <
[email protected]

wrote:

This pull request implements JGrid in some backend components.

This touches the users view of com_users and the categories view of
com_categories. These changes are 100% backwards compatible and will not
influence existing templates. For future templates, it will be easier to
modify the existing views and less code will be necessary for this.

This reduces the amount of code necessary for generating the backend
tables and simplifies the hathor overrides.

If the platform project accepts a change to JView, the tables could also
be modified by a plugin, maybe removing the need for overrides in quite a
few cases.

You can merge this Pull Request by running:

git pull https://github.com/Hackwar/joomla-cms jgrid

Or you can view, comment on it, or merge it online at:

#23

-- Commit Summary --

  • Implementing JGrid in com_users users view and com_categories categories
    view

-- File Changes --

M
administrator/components/com_categories/views/categories/tmpl/default.php
(109)
M administrator/components/com_categories/views/categories/view.html.php
(101)
M administrator/components/com_users/views/users/tmpl/default.php (117)
M administrator/components/com_users/views/users/tmpl/modal.php (41)
M administrator/components/com_users/views/users/view.html.php (149)
M
administrator/templates/hathor/html/com_categories/categories/default.php
(111)
M administrator/templates/hathor/html/com_users/users/default.php (125)
M administrator/templates/hathor/html/com_users/users/modal.php (49)

-- Patch Links --

https://github.com/joomla/joomla-cms/pull/23.patch
https://github.com/joomla/joomla-cms/pull/23.diff

Reply to this email directly or view it on GitHub:
#23

elinw referenced this pull request in elinw/joomla-cms Dec 11, 2011
@LouisLandry
Merge pull request #23 from realityking/php4
adeefc9 
Remove workaround for PHP 4 and PHP 5.2.3 in JFTP and JXMLElement.
@Hackwar
Copy link
Member Author

Hackwar commented Jan 15, 2012

Here is the tracker item: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=27725

@phproberto
Copy link
Contributor

I'm closing this as it's not mergeable and 2 years old. Feel free to open if you update it and are still interested in get it merged.

Thanks for contributing.

@phproberto phproberto closed this Oct 3, 2013
wilsonge referenced this pull request in wilsonge/joomla-cms Jun 12, 2014
@phproberto
Merge pull request #23 from phproberto/plugin-content-vote
86ffbec 
Plugin content vote
@Hackwar Hackwar deleted the jgrid branch December 10, 2014 09:14
infograf768 pushed a commit that referenced this pull request Jan 6, 2015
@zero-24
Merge pull request #23 from wilsonge/patch-16
21822ad 
Make code more readable
@FreeMindedMedia FreeMindedMedia mentioned this pull request Jul 13, 2015
Closed
rdeutz pushed a commit that referenced this pull request Oct 1, 2015
@infograf768
Merge pull request #23 from Bakual/DeprecateGetTitle
9474532 
Deprecate getTitle method
wilsonge added a commit that referenced this pull request Mar 5, 2016
@wilsonge
Merge pull request #23 from richard67/patch-1
aa0812a 
Check saved conversion status
wilsonge pushed a commit that referenced this pull request Apr 7, 2016
@laoneo
Merge pull request #23 from brianteeman/patch-1
a506ef8 
Simplification of language string 2
mwatt pushed a commit to mwatt/joomla-cms that referenced this pull request Jun 27, 2016
Merge pull request joomla#23 from Fedik/field-user-5655
b37e0ba 
Update the scripts to handle selected user
wilsonge pushed a commit that referenced this pull request Jan 23, 2017
@C-Lodder
Merge pull request #23 from C-Lodder/grid
a699437 
Dashboard and Installation - BS4 integration
wilsonge pushed a commit that referenced this pull request May 31, 2017
@brianteeman @wilsonge
[codestyle] admin components xml files (#15920)
6c66636 
* codestyle

* code style

* codestyle

* codestyle

* codestyle

* thanks @wojsmol

* corrections - thanks @Quy

* corrections - thanks @Quy

* oops

* make @Quy happy

* Update article.xml

* Remove space

* Update config.xml (#14)

* Update filter.xml (#15)

* Update config.xml (#16)

* Update profile.xml (#17)

* Update application.xml (#18)

* Update article.xml (#19)

* Update filter_articles.xml (#20)

* Update config.xml (#24)

* Update config.xml (#23)

* Update filter_fields.xml (#22)

* Update filter_featured.xml (#21)

* Update override.xml (#25)

* Update config.xml

* Update config.xml (#26)

* Update itemadmin_alias.xml (#30)

* Update itemadmin.xml (#29)

* Update item.xml (#27)

* Update item_alias.xml (#28)

* Update itemadmin_url.xml (#31)

* Update module.xml (#32)

* Update plugin.xml (#33)

* Update config.xml (#34)

* Update link.xml (#35)

* Update config.xml (#36)

* Update style.xml (#38)

* Update config.xml (#37)

* Update note.xml (#42)

* Update group.xml (#41)

* Update filter_debuggroup.xml (#40)

* Update config.xml (#39)

* corrections for @andrepereiradasilva

* gotya
richard67 referenced this pull request in richard67/joomla-cms Apr 3, 2020
@mbabker
Merge pull request #23 from zero-24/patch-1
f18da36 
Icon for the Toolbar in 3.x
obuisard added a commit to obuisard/joomla-cms that referenced this pull request Feb 21, 2023
@obuisard
Admin module database changes (joomla#23)
9bea92e 
* Added guided_tour module

* Missing data

* Database changes for admin module

* Update extensions.sql

changed asset ids in guidedtours table

* Update extensions.sql

assets to 0 in guidedtours table

* Update extensions.sql

assets to 0 in guidedtours table
shazmasiddiqui added a commit to shazmasiddiqui/joomla-cms that referenced this pull request Jul 12, 2023
@shazmasiddiqui
Merge pull request joomla#23 from joomla-projects/bembelimen/language…
de4ab57 
…files

Fix language files
SniperSister added a commit to SniperSister/joomla-cms that referenced this pull request Feb 12, 2024
@SniperSister
Merge pull request joomla#23 from brianteeman/lang
5301ba6 
Lang strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Hackwar @infograf768 @dextercowley @phproberto