Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] Extend 2FA Enforcement option to select usergroups #30522

Merged
merged 4 commits into from
Sep 22, 2020

Conversation

zero-24
Copy link
Contributor

@zero-24 zero-24 commented Aug 30, 2020

Pull Request for Issue #29321 cc @conconnl

Summary of Changes

Extend 2FA Enforcement option to select usergroups

image

Testing Instructions

  • Apply this patch
  • enable atleast one 2fa plugin
  • go to Users -> Manage -> Options
  • Set Enforce Two Factor Authentication to both
  • Add an usergroup (Superuser for example)
  • save and close the settings
  • you are now beeing forced to setup 2fa
  • login as an non-superuser
  • you are not forced to setup 2fa

Actual result BEFORE applying this Pull Request

You could not force 2fa to a specific usergroup

Expected result AFTER applying this Pull Request

You can now force 2fa to a specific usergroup

Documentation Changes Required

Additional option has to be documented.

Backports

That feature has been backported to 3.9+ here: https://github.com/zero-24/plg_system_force2fausergroup/releases/latest

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 30, 2020

Drone fails unrealted to the changes done here. It seems 4.1 composer stuff is broken: https://ci.joomla.org/joomla/joomla-cms/35096/1/8

@brianteeman
Copy link
Contributor

Thinking out aloud here but shouldnt it be a minimum usergroup. IT wouldnt make sense to force 2fa on a manager but not on an administrator

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 31, 2020

I get your point but i'm not sure whether we should implement such hierachie reading given that on bigger sites this could get quite complex. And that would lock every site owner to that rule without (for whatever reason) exception.

There might be someone above Administrator in the Hierarchie but they are not allowed to do com_users so they choose to not force 2fa to them but all other groups above Administrator should be forced to setup 2fa.

With the solution provided here both is possible with us writing non complex code and it is transparent to the site admin which group is forced to setup 2fa

@ghost
Copy link

ghost commented Aug 31, 2020

I have tested this item ✅ successfully on c9f2ae6

Works as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30522.

@conconnl
Copy link
Member

I have tested this item ✅ successfully on c9f2ae6

It works as expected.

@zero-24 zero-24 changed the title [4.1] Extend 2FA Enforcement option to select usergroups [4.1] Extend 2FA Enforcement option to select usergroups Aug 31, 2020
@zero-24
Copy link
Contributor Author

zero-24 commented Aug 31, 2020

RTC Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30522.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.1-dev RTC This Pull Request is Ready To Commit labels Aug 31, 2020
@zero-24 zero-24 added this to the Joomla 4.1 milestone Aug 31, 2020
@laoneo
Copy link
Member

laoneo commented Aug 31, 2020

Restartet drone

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 31, 2020

Drone seems to be a more general problem with the 4.1 branch: https://ci.joomla.org/joomla/joomla-cms/35141/1/8 unrealted to this PR for sure.

@wilsonge
Copy link
Contributor

wilsonge commented Sep 12, 2020

I just merged 4.0-dev into 4.1-dev. can you merge in latest 4.1-dev here and see if it fixes the issue please?

@zero-24
Copy link
Contributor Author

zero-24 commented Sep 14, 2020

PR has been updated.

@wilsonge wilsonge merged commit 85b4d78 into joomla:4.1-dev Sep 22, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 22, 2020
@wilsonge
Copy link
Contributor

Thanks!

@zero-24 zero-24 deleted the force2fausergroup branch September 22, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants