-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.1] Extend 2FA Enforcement option to select usergroups #30522
Conversation
Drone fails unrealted to the changes done here. It seems 4.1 composer stuff is broken: https://ci.joomla.org/joomla/joomla-cms/35096/1/8 |
Thinking out aloud here but shouldnt it be a minimum usergroup. IT wouldnt make sense to force 2fa on a manager but not on an administrator |
I get your point but i'm not sure whether we should implement such hierachie reading given that on bigger sites this could get quite complex. And that would lock every site owner to that rule without (for whatever reason) exception. There might be someone above Administrator in the Hierarchie but they are not allowed to do com_users so they choose to not force 2fa to them but all other groups above Administrator should be forced to setup 2fa. With the solution provided here both is possible with us writing non complex code and it is transparent to the site admin which group is forced to setup 2fa |
I have tested this item ✅ successfully on c9f2ae6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30522. |
I have tested this item ✅ successfully on c9f2ae6
|
RTC Thanks! This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30522. |
Co-authored-by: Quy <[email protected]>
Restartet drone |
Drone seems to be a more general problem with the 4.1 branch: https://ci.joomla.org/joomla/joomla-cms/35141/1/8 unrealted to this PR for sure. |
I just merged 4.0-dev into 4.1-dev. can you merge in latest 4.1-dev here and see if it fixes the issue please? |
PR has been updated. |
Thanks! |
joomla/joomla-cms#30522 + joomla/joomla-cms#32223 + joomla/joomla-cms#31675 + joomla/joomla-cms#35378 + joomla/joomla-cms#35612 + joomla/joomla-cms#35715 + joomla/joomla-cms#35610 + joomla/joomla-cms#35607 + joomla/joomla-cms#35788 + joomla/joomla-cms#35647 + joomla/joomla-cms#35143 + joomla/joomla-cms#36135 + joomla/joomla-cms#35998 + joomla/joomla-cms#36173 + joomla/joomla-cms#36212 + joomla/joomla-cms#36208 + joomla/joomla-cms#36206 + joomla/joomla-cms#36205 + joomla/joomla-cms#36203 + joomla/joomla-cms#36192 + joomla/joomla-cms#36191 + joomla/joomla-cms#36228 + joomla/joomla-cms#36211 + joomla/joomla-cms#36271 + joomla/joomla-cms#36270 + joomla/joomla-cms#36245 + joomla/joomla-cms#36294 + joomla/joomla-cms#36244 + joomla/joomla-cms#36242 + joomla/joomla-cms#36296 + joomla/joomla-cms#36190 + joomla/joomla-cms#36474 + joomla/joomla-cms#36297 + joomla/joomla-cms#36480 + joomla/joomla-cms#36479 + joomla/joomla-cms#36551 + joomla/joomla-cms#36366 + joomla/joomla-cms#36589 + joomla/joomla-cms#36583 + joomla/joomla-cms#36328 + joomla/joomla-cms#36515 + joomla/joomla-cms#36555 + joomla/joomla-cms#36653 + joomla/joomla-cms#36660 + joomla/joomla-cms#36657 + joomla/joomla-cms#36637 + joomla/joomla-cms#35983 + joomla/joomla-cms#36704 + joomla/joomla-cms#36708 + joomla/joomla-cms#36700 +
Pull Request for Issue #29321 cc @conconnl
Summary of Changes
Extend 2FA Enforcement option to select usergroups
Testing Instructions
Users
->Manage
->Options
Enforce Two Factor Authentication
to bothActual result BEFORE applying this Pull Request
You could not force 2fa to a specific usergroup
Expected result AFTER applying this Pull Request
You can now force 2fa to a specific usergroup
Documentation Changes Required
Additional option has to be documented.
Backports
That feature has been backported to 3.9+ here: https://github.com/zero-24/plg_system_force2fausergroup/releases/latest