[4.0] pre-update check #33393
Merged
[4.0] pre-update check #33393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when moving from bs2 to bs5 the label-* classes were changed to alert-* classes however there is no such class as alert-important - it should be alert-danger
Quy
reviewed
Apr 28, 2021
administrator/components/com_joomlaupdate/tmpl/joomlaupdate/default_preupdatecheck.php
Show resolved
Hide resolved
|
I have tested this item ✅ successfully on f216014 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33393. |
1 similar comment
|
I have tested this item ✅ successfully on f216014 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33393. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33393. |
Quy
added
PR-4.0-dev
RTC
|
Thanks! |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when moving from bs2 to bs5 the label-* classes were changed to alert-* classes
however there is no such class as alert-important - it should be alert-danger
before
after