[4.1] Adapter trait unification #36097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilETaylor
reviewed
Nov 23, 2021
administrator/components/com_media/src/Provider/ProviderManagerHelperTrait.php
Outdated
Show resolved
Hide resolved
PhilETaylor
reviewed
Nov 23, 2021
administrator/components/com_media/src/Provider/ProviderManagerHelperTrait.php
Outdated
Show resolved
Hide resolved
…rHelperTrait.php Co-authored-by: Phil E. Taylor <[email protected]>
…rHelperTrait.php Co-authored-by: Phil E. Taylor <[email protected]>
|
I have tested this item ✅ successfully on bfe7daa This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36097. |
1 similar comment
|
I have tested this item ✅ successfully on bfe7daa This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36097. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36097. |
|
Thx |
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jan 9, 2022
bembelimen
added a commit
that referenced
this pull request
Jan 15, 2022
) * Update deleted files and folders to changes from PR #36097 . * Fix comment in the folders array, too * Grr Co-authored-by: Benjamin Trenkle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This is a followup pr of #35788 which unifies the usage across the media manager to load the adapters.
Testing Instructions
Open the media manager in the back end and browse around and upload delete images.
Actual result BEFORE applying this Pull Request
All is working.
Expected result AFTER applying this Pull Request
All is working.