Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] Support API save requests with adapter #36116

Merged
merged 13 commits into from
Jan 6, 2022

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Nov 25, 2021

Bugfix Pull Request for pr #35788.

Summary of Changes

POST and PATCH are not working for the media web service when an adapter is set.

Testing Instructions

curl --location --request PATCH 'https://[your J4 website]/api/index.php/v1/files/local-images:/joomla_black.png' \
--header 'Content-Type: application/json' \
--header 'X-Joomla-Token: [your user token]' \
--data-raw '{
    "path": "local-images:/joomla_black.png",
    "content": "[your base64 content]"
}'

Actual result BEFORE applying this Pull Request

Returns 404 not found and image is not created.

Expected result AFTER applying this Pull Request

Returns 200 and image contains the new created.

@alikon
Copy link
Contributor

alikon commented Dec 2, 2021

now it works with and without adapters
image

@alikon
Copy link
Contributor

alikon commented Dec 2, 2021

I have tested this item ✅ successfully on 1e73289


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36116.

@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on 2630c17


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36116.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 4.1 milestone Jan 6, 2022
@alikon
Copy link
Contributor

alikon commented Jan 6, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36116.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 6, 2022
@bembelimen bembelimen merged commit c411214 into joomla:4.1-dev Jan 6, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 6, 2022
@bembelimen
Copy link
Contributor

Thanks

@bembelimen bembelimen added this to the Joomla 4.1 milestone Jan 6, 2022
@laoneo laoneo deleted the j4/media/ws/adapter branch January 6, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants