[4.0][bugfix] Fix Figure misbehaviour in tinyMCE

[dgrammatiko]

Pull Request for Issue, sorry couldn't found the one...

Summary of Changes

• Adds a class image to the figure element as tinyMCE expects that to enable the editing of the figcaption text

Testing Instructions

This Pr needs NPM

• Fetch and run npm install
• Try to select an image using the Joomla dropdown icon and then selecting media
• Add some figure class and some text for the figure caption
• You should have a boxed area around the image and clicking in the caption text you should be able to edit it

Actual result BEFORE applying this Pull Request

Editing a figure element is kinda broken

Expected result AFTER applying this Pull Request

Editing a figure element is easier

Documentation Changes Required

No

@brianteeman @N6REJ

[N6REJ]

I have tested this item ✅ successfully on c54a3fe

Works exactly as expected

---

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36221.</sub

[N6REJ]

@dgrammatiko nice and simple. If I could make a user request might be handy to have a.. switch(?)... to move caption before/after image.

[dgrammatiko]

if I could make a user request might be handy to have a.. switch(?)... to move caption before/after image.

Do you mean something like:

<!-- before -->
<figure>
  <figcaption>
  <img ... >
</figure>

<!-- after -->
<figure>
  <img ... >
  <figcaption>
</figure>

TBH I had to check MDN as I had the impression that figcaption could only go as the last element of the figcaption, and clearly, that's not what the specs say: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/figcaption. Give me some time to think how that could be done

[brianteeman]

I have tested this item ✅ successfully on c54a3fe

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36221.}

[brianteeman]

I have tested this item 🔴 unsuccessfully on c54a3fe

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36221.}

[dgrammatiko]

@brianteeman what failed here?

[brianteeman]

oops sorry I meant to change it to untested

[brianteeman]

I have not tested this item.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36221.}

[brianteeman]

tested correctly now

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36221.}

[brianteeman]

I have tested this item ✅ successfully on c54a3fe

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36221.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36221.}

[N6REJ]

if I could make a user request might be handy to have a.. switch(?)... to move caption before/after image.

Do you mean something like:

<!-- before -->
<figure>
  <figcaption>
  <img ... >
</figure>

<!-- after -->
<figure>
  <img ... >
  <figcaption>
</figure>

TBH I had to check MDN as I had the impression that figcaption could only go as the last element of the figcaption, and clearly, that's not what the specs say: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/figcaption. Give me some time to think how that could be done

ty, thats exactly what I meant. I appreciate you doing the extra effort

[Quy]

Thanks