Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert mod_messages to service provider #42735

Merged
merged 14 commits into from
Feb 27, 2024

Conversation

joomlaweby
Copy link
Contributor

Summary of Changes

Converts the messages administrator module to service provider.

This is my first pull request to Joomla! project :-).

Testing Instructions

  1. Make sure you have administrator component com_messages (Private Messages) and module mod_messages enabled
  2. Make sure you have at least 1 unread message
  3. You should see module output

mod_messages

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@fgsw
Copy link

fgsw commented Feb 3, 2024

I have tested this item ✅ successfully on 24ba818


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42735.

@richard67
Copy link
Member

@joomlaweby No need to update your branch when there are no conflicts shown. Updating the branch in validates the test counter for human test. I've restored the result from @fgsw now so it's counted again.

@joomlaweby
Copy link
Contributor Author

@joomlaweby No need to update your branch when there are no conflicts shown. Updating the branch in validates the test counter for human test. I've restored the result from @fgsw now so it's counted again.

@richard67 OK, got it. :-)

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 769c4ab


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42735.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42735.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 22, 2024
@exlemor
Copy link

exlemor commented Feb 24, 2024

Tested successfully during PBF 2024.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42735.

@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Feb 25, 2024
@LadySolveig LadySolveig merged commit dad1882 into joomla:5.1-dev Feb 27, 2024
2 of 3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 27, 2024
@LadySolveig
Copy link
Contributor

Thank you @joomlaweby and also for testing and support @fgsw @viocassel @exlemor @richard67 @sandewt

heelc29 added a commit to heelc29/joomla-cms that referenced this pull request Feb 27, 2024
heelc29 added a commit to heelc29/joomla-cms that referenced this pull request Feb 27, 2024
@joomlaweby joomlaweby deleted the mod-messages branch January 1, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants