-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert mod_messages to service provider #42735
Conversation
administrator/modules/mod_messages/src/Dispatcher/Dispatcher.php
Outdated
Show resolved
Hide resolved
administrator/modules/mod_messages/src/Helper/MessagesHelper.php
Outdated
Show resolved
Hide resolved
administrator/modules/mod_messages/src/Dispatcher/Dispatcher.php
Outdated
Show resolved
Hide resolved
I have tested this item ✅ successfully on 24ba818 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42735. |
@joomlaweby No need to update your branch when there are no conflicts shown. Updating the branch in validates the test counter for human test. I've restored the result from @fgsw now so it's counted again. |
|
I have tested this item ✅ successfully on 769c4ab This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42735. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42735. |
Tested successfully during PBF 2024. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42735. |
Thank you @joomlaweby and also for testing and support @fgsw @viocassel @exlemor @richard67 @sandewt |
fix return value
fix return value
Summary of Changes
Converts the messages administrator module to service provider.
This is my first pull request to Joomla! project :-).
Testing Instructions
Actual result BEFORE applying this Pull Request
Module works as expected
Expected result AFTER applying this Pull Request
Module works same way as before applying pull request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed