-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Update Jooa11y with latest Sa11y build (Attempt #2) #42780
Conversation
Work in progress
Account for empty values
Work in progress
Account for empty values
Thanks! |
Co-authored-by: Quy <[email protected]>
Co-authored-by: Brian Teeman <[email protected]>
And now I'm done embarrassing myself!
That is not my understanding of the help text which is in two parts
implies these three checks will always take place
implies that the settings are not exposed to the user. From my understanding of the behaviour that takes place then the help text should be
|
Works for me, makes more sense. |
A release lead needs to decide if it is ok to delete all these unused strings r if we must follow previous policy that they should be deprecated instead |
@adamchaboryk I made another PR for string deprecation adamchaboryk#3 |
Deprecate strings
Co-authored-by: Brian Teeman <[email protected]>
Co-authored-by: Brian Teeman <[email protected]>
Co-authored-by: Brian Teeman <[email protected]>
will give it a more detailed test tomottow but it looks good to me |
I have tested this item ✅ successfully on 9144751 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42780. |
r2c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42780. |
Added the language strings deprecation also to to the migration section in the documentation |
great -= thanks all |
Thank you so much @adamchaboryk for your work and for taking care on the implementation into Joomla and this very nice new features 🚀 |
Thank you, Martina! I'm super excited for 5.1! I'm also very grateful for all the support and guidance from everyone. Looking forward to future collaborations! |
Continuation of #42768 based on @Fedik's review and feedback. Includes updated screenshots of changes.
(Sorry for re-creating the PR. Had issues re-basing from 5.0 to 5.1. After I renamed the branch on my fork, I inadvertently closed my PR.)
Summary of Changes
This PR adds Sa11y as a dependency, ensuring seamless and automatic updates for future Joomla releases.
build/build-modules-js/settings.json
.build/build-modules-js/settings.json
.Related issue: joomla-projects/joomla-a11y-checker#75
Testing Instructions
npm install
Actual result BEFORE applying this Pull Request
https://joomla-projects.github.io/joomla-a11y-checker/pages/errors.html
Expected result AFTER applying this Pull Request
Accessibility Check preview
Plugin settings with descriptions
Includes a couple of Extra Props for demonstration purposes. Extra props can accept boolean/numeric/string based on Sa11y's documentation.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: I'll do a PR later to update this page https://manual.joomla.org/docs/accessibility/testing
No documentation changes for manual.joomla.org needed