-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Convert mod_version to service provider #42814
Conversation
I have tested this item ✅ successfully on 366e884 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42814. |
administrator/modules/mod_version/src/Dispatcher/Dispatcher.php
Outdated
Show resolved
Hide resolved
I have tested this item ✅ successfully on 6be703c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42814. |
@fgsw Could you test this PR again? Thanks in advance. |
@fgsw I've restored the result from your previous test in the issue tracker since the changes after that were code style only. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42814. |
Thank you @joomlaweby for your work and your endurance! |
Summary of Changes
Converts the version administrator module to service provider.
Testing Instructions
Actual result BEFORE applying this Pull Request
Module works as expected
Expected result AFTER applying this Pull Request
Module works same way as before applying pull request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed