-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Convert mod_tags_similar to service provider #42898
Conversation
I have tested this item ✅ successfully on ab215d4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42898. |
1 similar comment
I have tested this item ✅ successfully on ab215d4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42898. |
What means "Service Provider"? |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42898. |
@fgsw Simple explanation is, that it is a new way, how extensions in Joomla works since 4.0. I found more technical explanation here: https://docs.joomla.org/J4.x:Dependency_Injection_in_Joomla_4#Providers For example in mod_articles_latest extension it is this file: https://github.com/joomla/joomla-cms/blob/5.1-dev/modules/mod_articles_latest/services/provider.php |
Thank you @joomlaweby and also for testing @viocassel and @fgsw |
Summary of Changes
Converts the tags similar site module to service provider.
Testing Instructions
Actual result BEFORE applying this Pull Request
Module works as expected
Expected result AFTER applying this Pull Request
Module works same way as before applying pull request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed