Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Convert mod_tags_similar to service provider #42898

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

joomlaweby
Copy link
Contributor

Summary of Changes

Converts the tags similar site module to service provider.

Testing Instructions

  1. Make sure you have site module mod_tags_similar published
  2. Add some tags and assign them to several content items
  3. You should see module output on content items, which have at least 1 tag assigned and this tag is assigned also on another content items.

mod_tags_similar

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@bembelimen bembelimen added this to the Joomla! 5.1.0 milestone Feb 26, 2024
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on ab215d4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42898.

1 similar comment
@fgsw
Copy link

fgsw commented Feb 27, 2024

I have tested this item ✅ successfully on ab215d4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42898.

@fgsw
Copy link

fgsw commented Feb 27, 2024

What means "Service Provider"?

@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 5.1.0 milestone Feb 27, 2024
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42898.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 27, 2024
@joomlaweby
Copy link
Contributor Author

What means "Service Provider"?

@fgsw Simple explanation is, that it is a new way, how extensions in Joomla works since 4.0. I found more technical explanation here: https://docs.joomla.org/J4.x:Dependency_Injection_in_Joomla_4#Providers

For example in mod_articles_latest extension it is this file: https://github.com/joomla/joomla-cms/blob/5.1-dev/modules/mod_articles_latest/services/provider.php

@LadySolveig LadySolveig merged commit ca3faf7 into joomla:5.1-dev Feb 28, 2024
0 of 2 checks passed
@LadySolveig
Copy link
Contributor

Thank you @joomlaweby and also for testing @viocassel and @fgsw

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 28, 2024
@Quy Quy added this to the Joomla! 5.1.0 milestone Feb 28, 2024
@joomlaweby joomlaweby deleted the mod_tags_similar branch January 1, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants