Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Composer update joomla/application to 3.0.3 to fix PHP deprecations in Web Client #44585

Conversation

richard67
Copy link
Member

@richard67 richard67 commented Dec 4, 2024

Pull Request for Issues #39960 , #39637 , #43334 , #43916 and #44469 .

Summary of Changes

This pull request (PR) updates the composer dependency "joomla/application" from version 3.0.2 to version 3.0.3.

See https://github.com/joomla-framework/application/releases/tag/3.0.3 for the changes.

Testing Instructions

  1. For issue [4.2] WebClient.php deprecated elements on PHP8.1 #39960 : Make a GET request to a page on the site (frontend) without a User Agent header.
  2. For issues [4.2] webclient user agents #39637 and [5.2] deprecated warning in error_log caused by detectEngine() if $userAgent contains "Chrome" but no version after a space character #44469 : Make a GET request to a page on the site (frontend) with User Agent "Chrome Privacy Preserving Prefetch Proxy".

You can modify the User Agent header in the developer tools of your browser.

Actual result BEFORE applying this Pull Request

  1. PHP warning Deprecated: strpos(): Passing null to parameter #1 ($haystack) at several places.
  2. PHP warning Undefined array key 1 in libraries/vendor/joomla/application/src/Web/WebClient.php on line 439.

Expected result AFTER applying this Pull Request

  1. No such PHP warning.
  2. No such PHP warning.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

@alikon
Copy link
Contributor

alikon commented Dec 7, 2024

I have tested this item ✅ successfully on 81d9d00


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44585.

@HLeithner HLeithner merged commit 33c9c7c into joomla:5.2-dev Dec 8, 2024
3 of 4 checks passed
@HLeithner
Copy link
Member

Thanks, second test has been done by quy (has issues with his github account at the moment)

@richard67 richard67 deleted the 5.2-dev-composer-update-joomla-application-3-0-3 branch December 8, 2024 09:57
@richard67
Copy link
Member Author

Thanks for tests and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants