Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve modulation for large protocols #330

Merged
merged 1 commit into from
Sep 17, 2017
Merged

Improve modulation for large protocols #330

merged 1 commit into from
Sep 17, 2017

Conversation

jopohl
Copy link
Owner

@jopohl jopohl commented Sep 16, 2017

Prevent spikes for late bursts due to number overflows

@jopohl jopohl requested a review from andynoack September 16, 2017 10:27
andynoack
andynoack approved these changes Sep 17, 2017
View reviewed changes
Copy link
Collaborator

@andynoack andynoack left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me! Modulation of the failing signal (confirmed failing with master branch) is correct right now

@jopohl jopohl merged commit a9dbb86 into master Sep 17, 2017
@jopohl jopohl deleted the improve_modulation branch September 17, 2017 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andynoack andynoack andynoack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jopohl @andynoack