Fixed error in reading parquet (#816)

jorgecarleitao · Feb 5, 2022 · 7d585ee · 7d585ee
1 parent 23be712
commit 7d585ee
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/io/parquet/read/binary/basic.rs b/src/io/parquet/read/binary/basic.rs
@@ -255,7 +255,7 @@ impl<'a, O: Offset> utils::Decoder<'a, &'a [u8], Binary<O>> for BinaryDecoder<O>
                 &mut page.values,
             ),
             State::RequiredDictionary(page) => {
-                page.remaining -= additional;
+                page.remaining = page.remaining.saturating_sub(additional);
                 for x in page.values.by_ref().take(additional) {
                     values.push(x)
                 }

diff --git a/src/io/parquet/read/primitive/basic.rs b/src/io/parquet/read/primitive/basic.rs
@@ -209,13 +209,13 @@ where
                     ValuesDictionary::new(values_buffer, page.num_values(), dict, self.op2),
                 ))
             }
-            (Encoding::Plain, None, true) => {
+            (Encoding::Plain, _, true) => {
                 let validity = OptionalPageValidity::new(page);
                 let values = Values::new(page, self.op1, self.op2);
 
                 Ok(State::Optional(validity, values))
             }
-            (Encoding::Plain, None, false) => {
+            (Encoding::Plain, _, false) => {
                 Ok(State::Required(Values::new(page, self.op1, self.op2)))
             }
             _ => Err(utils::not_implemented(