Avoid repetitions in can_* functions

jorgecarleitao · Sep 23, 2021 · f2df942 · f2df942
1 parent b758df9
commit f2df942
Showing 1 changed file with 12 additions and 28 deletions.
diff --git a/src/compute/temporal.rs b/src/compute/temporal.rs
@@ -362,20 +362,18 @@ where
 /// assert_eq!(can_year(&data_type), false);
 /// ```
 pub fn can_year(data_type: &DataType) -> bool {
-    matches!(
-        data_type,
-        DataType::Date32 | DataType::Date64 | DataType::Timestamp(_, _)
-    )
+    can_date(data_type)
 }
 
 pub fn can_month(data_type: &DataType) -> bool {
-    matches!(
-        data_type,
-        DataType::Date32 | DataType::Date64 | DataType::Timestamp(_, _)
-    )
+    can_date(data_type)
 }
 
 pub fn can_day(data_type: &DataType) -> bool {
+    can_date(data_type)
+}
+
+fn can_date(data_type: &DataType) -> bool {
     matches!(
         data_type,
         DataType::Date32 | DataType::Date64 | DataType::Timestamp(_, _)
@@ -396,32 +394,18 @@ pub fn can_day(data_type: &DataType) -> bool {
 /// assert_eq!(can_hour(&data_type), false);
 /// ```
 pub fn can_hour(data_type: &DataType) -> bool {
-    matches!(
-        data_type,
-        DataType::Time32(TimeUnit::Second)
-            | DataType::Time32(TimeUnit::Millisecond)
-            | DataType::Time64(TimeUnit::Microsecond)
-            | DataType::Time64(TimeUnit::Nanosecond)
-            | DataType::Date32
-            | DataType::Date64
-            | DataType::Timestamp(_, _)
-    )
+    can_time(data_type)
 }
 
 pub fn can_minute(data_type: &DataType) -> bool {
-    matches!(
-        data_type,
-        DataType::Time32(TimeUnit::Second)
-            | DataType::Time32(TimeUnit::Millisecond)
-            | DataType::Time64(TimeUnit::Microsecond)
-            | DataType::Time64(TimeUnit::Nanosecond)
-            | DataType::Date32
-            | DataType::Date64
-            | DataType::Timestamp(_, _)
-    )
+    can_time(data_type)
 }
 
 pub fn can_second(data_type: &DataType) -> bool {
+    can_time(data_type)
+}
+
+fn can_time(data_type: &DataType) -> bool {
     matches!(
         data_type,
         DataType::Time32(TimeUnit::Second)