Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Writing nested slice roundtrip fails (parquet) #1394

Closed
ritchie46 opened this issue Feb 11, 2023 · 2 comments
Closed

Writing nested slice roundtrip fails (parquet) #1394

ritchie46 opened this issue Feb 11, 2023 · 2 comments
Labels
bug Something isn't working no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog

Comments

@ritchie46
Copy link
Collaborator

I tried to update to 7be484e, but this test failed in polars.

 def test_nested_sliced() -> None:
    for df in [
        pl.Series([[1, 2], [3, 4], [5, 6]]).slice(2, 2).to_frame(),
        pl.Series([[None, 2], [3, 4], [5, 6]]).to_frame(),
        pl.Series([[None, 2], [3, 4], [5, 6]]).slice(2, 2).to_frame(),
        pl.Series([["a", "a"], ["", "a"], ["c", "de"]]).slice(3, 2).to_frame(),
        pl.Series([[None, True], [False, False], [True, True]]).slice(2, 2).to_frame(),
    ]:
        f = io.BytesIO()
        df.write_parquet(f)
        f.seek(0)
       assert_frame_equal(pl.read_parquet(f), df)

left = shape: (1, 1)
┌───────────┐
│           │
│ ---       │
│ list[i64] │
╞═══════════╡
│ [null, 5] │
└───────────┘
right = shape: (1, 1)
┌───────────┐
│           │
│ ---       │
│ list[i64] │
╞═══════════╡
│ [5, 6]    │
└───────────┘

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Feb 12, 2023
@jorgecarleitao
Copy link
Owner

On it

@jorgecarleitao
Copy link
Owner

Fixed by #1397

@jorgecarleitao jorgecarleitao added the no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog label Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog
Projects
None yet
Development

No branches or pull requests

2 participants