Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed writing of sliced arrays to parquet #1397

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Conversation

jorgecarleitao
Copy link
Owner

It also improves performance of writing in general

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Feb 12, 2023
@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Base: 83.44% // Head: 83.50% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (45b7154) compared to base (d7d7239).
Patch coverage: 95.06% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1397      +/-   ##
==========================================
+ Coverage   83.44%   83.50%   +0.06%     
==========================================
  Files         373      373              
  Lines       40721    40678      -43     
==========================================
- Hits        33979    33970       -9     
+ Misses       6742     6708      -34     
Impacted Files Coverage Δ
src/buffer/immutable.rs 90.10% <ø> (+5.49%) ⬆️
src/io/parquet/write/mod.rs 88.07% <86.25%> (+1.69%) ⬆️
src/io/parquet/write/binary/nested.rs 96.77% <100.00%> (+1.53%) ⬆️
src/io/parquet/write/nested/def.rs 99.19% <100.00%> (-0.01%) ⬇️
src/io/parquet/write/nested/rep.rs 99.00% <100.00%> (+<0.01%) ⬆️
src/io/parquet/write/pages.rs 96.13% <100.00%> (+0.28%) ⬆️
src/io/parquet/write/primitive/nested.rs 97.22% <100.00%> (+1.38%) ⬆️
src/io/parquet/write/utf8/nested.rs 96.77% <100.00%> (+1.65%) ⬆️
src/offset.rs 86.30% <100.00%> (+2.73%) ⬆️
src/io/ipc/read/array/boolean.rs 92.45% <0.00%> (-5.67%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jorgecarleitao jorgecarleitao merged commit b94e6f6 into main Feb 13, 2023
@jorgecarleitao jorgecarleitao deleted the slice_parquet branch February 13, 2023 06:01
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Mar 29, 2023
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant