Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Change DataType::FixedSize*(i32) to DataType::FixedSize*(usize) #525

Closed
jorgecarleitao opened this issue Oct 12, 2021 · 0 comments · Fixed by #556
Closed

Change DataType::FixedSize*(i32) to DataType::FixedSize*(usize) #525

jorgecarleitao opened this issue Oct 12, 2021 · 0 comments · Fixed by #556
Labels
backwards-incompatible good first issue Good for newcomers no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog

Comments

@jorgecarleitao
Copy link
Owner

jorgecarleitao commented Oct 12, 2021 •
edited
Loading

This artifact from java has no place in Rust :P; we just need an i32 at interface boundaries, not throughout the whole code.

Thanks to @lyuben-todorov that raised this here
@jorgecarleitao jorgecarleitao added the good first issue Good for newcomers label Oct 23, 2021
simonvandel added a commit to simonvandel/arrow2 that referenced this issue Oct 30, 2021
@simonvandel
Change DataType::FixedSize*(i32) to DataType::FixedSize*(usize)
fa92b66 
Fixes jorgecarleitao#525
@simonvandel simonvandel mentioned this issue Oct 30, 2021
Merged
jorgecarleitao pushed a commit that referenced this issue Oct 30, 2021
@simonvandel
Changed DataType::FixedSize*(i32) to DataType::FixedSize*(usize) (#556)
5776c81 
Fixes #525
@jorgecarleitao jorgecarleitao added the no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog label Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
backwards-incompatible good first issue Good for newcomers no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed DataType::FixedSize*(i32) to DataType::FixedSize*(usize) simonvandel/arrow2
1 participant
@jorgecarleitao