This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Improved performance of deserializing JSON (2x) #1024
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
serde_json
byjson_deserializer
, improving the performance of reading json strings by 2x and boolean by -30%, and +10% for floats:Note that there is an API change: we now require to pass
json_deserializer::Value
, notserde_json::Value
, to the deserializer.json_deserializer
is exposed underarrow2::io::json::read::json_deserializer
for convenience / version matching.