Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Improved performance in lexical write (~5%) #1067

Merged
merged 2 commits into from
Jun 10, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/util/lexical.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,19 @@ pub fn lexical_to_bytes_mut<N: lexical_core::ToLexical>(n: N, buf: &mut Vec<u8>)
// Length of buf is set as written length afterwards. lexical_core
// creates a valid string, so doesn't need to be checked.
let slice = std::slice::from_raw_parts_mut(buf.as_mut_ptr(), buf.capacity());
let len = lexical_core::write(n, slice).len();
buf.set_len(len);

// Safety:
// Omits an unneeded bound check as we just ensured that we reserved `N::FORMATTED_SIZE_DECIMAL`
#[cfg(debug_assertions)]
{
let len = lexical_core::write(n, slice).len();
buf.set_len(len);
}
#[cfg(not(debug_assertions))]
{
let len = lexical_core::write_unchecked(n, slice).len();
buf.set_len(len);
}
}
}

Expand Down