This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In line to what we already do for
Utf8
this PR omits bound checks forDictionary
andList
types when converting from aGrowable
to arrays. The bound checks can be removed because of the invariants of theGrowable
struct.I added assertions for debug builds for all the data types where we removed the bounds checks so that implementation bugs will be caught.
Finally I dispatched the
From
impls toStruct::to
to make the code more dry.