Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

release memory on predicate with 0% selectivity #1163

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

ritchie46
Copy link
Collaborator

When we selected no data from an array, we sliced the buffer keeping all the data in memory. This ensures we are able to free the array data by creating a new empty array.

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #1163 (da64106) into main (8c47777) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1163      +/-   ##
==========================================
- Coverage   83.58%   83.58%   -0.01%     
==========================================
  Files         365      365              
  Lines       35908    35908              
==========================================
- Hits        30015    30012       -3     
- Misses       5893     5896       +3     
Impacted Files Coverage Δ
src/compute/filter.rs 69.90% <0.00%> (ø)
src/array/utf8/mod.rs 85.62% <0.00%> (-0.96%) ⬇️
src/io/ipc/read/schema.rs 95.17% <0.00%> (-0.33%) ⬇️
src/bitmap/utils/slice_iterator.rs 98.78% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c47777...da64106. Read the comment docs.

@ritchie46 ritchie46 marked this pull request as draft July 13, 2022 09:00
@ritchie46 ritchie46 marked this pull request as ready for review July 13, 2022 09:06
@jorgecarleitao jorgecarleitao added the bug Something isn't working label Jul 13, 2022
@jorgecarleitao jorgecarleitao merged commit a8b526f into jorgecarleitao:main Jul 13, 2022
@jorgecarleitao
Copy link
Owner

Oooof, this was a nasty one!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants