Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

fix(parquet): allow to read other logical types from parquet #1168

Merged
merged 2 commits into from
Jul 19, 2022

Conversation

sundy-li
Copy link
Collaborator

No description provided.

@sundy-li sundy-li changed the title fix(parquet): enforce to use for PhysicalType::Int96 fix(parquet): allow to read other logical types from parquet Jul 19, 2022
@sundy-li sundy-li requested a review from jorgecarleitao July 19, 2022 01:36
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #1168 (4cdf6ff) into main (3fdb33f) will decrease coverage by 0.00%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main    #1168      +/-   ##
==========================================
- Coverage   83.73%   83.73%   -0.01%     
==========================================
  Files         365      365              
  Lines       35847    35859      +12     
==========================================
+ Hits        30018    30027       +9     
- Misses       5829     5832       +3     
Impacted Files Coverage Δ
src/io/parquet/read/deserialize/simple.rs 82.83% <50.00%> (-0.97%) ⬇️
src/io/parquet/read/deserialize/mod.rs 85.81% <91.66%> (-0.10%) ⬇️
src/io/ipc/read/array/boolean.rs 90.74% <0.00%> (-7.41%) ⬇️
src/bitmap/utils/slice_iterator.rs 97.56% <0.00%> (-1.22%) ⬇️
src/io/ipc/read/reader.rs 96.32% <0.00%> (+0.33%) ⬆️
src/io/ipc/read/file_async.rs 61.19% <0.00%> (+0.74%) ⬆️
src/array/binary/mod.rs 90.12% <0.00%> (+1.23%) ⬆️
src/io/ipc/read/stream_async.rs 76.71% <0.00%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fdb33f...4cdf6ff. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit cac624c into jorgecarleitao:main Jul 19, 2022
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Jul 19, 2022
@jorgecarleitao
Copy link
Owner

Thanks a lot, @sundy-li , sorry for my late review - vacations until end of this week with limited internet access.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants