Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

FileSink now closes the underlying writer. #1213

Merged
merged 1 commit into from
Aug 5, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/io/parquet/write/sink.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use ahash::AHashMap;
use std::{pin::Pin, task::Poll};

use futures::{future::BoxFuture, AsyncWrite, FutureExt, Sink, TryFutureExt};
use futures::{future::BoxFuture, AsyncWrite, AsyncWriteExt, FutureExt, Sink, TryFutureExt};
use parquet2::metadata::KeyValue;
use parquet2::write::FileStreamer;
use parquet2::write::WriteOptions as ParquetWriteOptions;
Expand Down Expand Up @@ -218,6 +218,7 @@ where

this.task = Some(Box::pin(async move {
writer.end(kv_meta).map_err(Error::from).await?;
writer.into_inner().close().map_err(Error::from).await?;
Ok(None)
}));
this.poll_complete(cx)
Expand Down