-
Notifications
You must be signed in to change notification settings - Fork 224
Added BinaryArray::into_mut
and double-ended support for its iterator
#1255
Conversation
Codecov ReportBase: 83.12% // Head: 83.12% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1255 +/- ##
==========================================
- Coverage 83.12% 83.12% -0.01%
==========================================
Files 359 359
Lines 38087 38152 +65
==========================================
+ Hits 31661 31715 +54
- Misses 6426 6437 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hey @jorgecarleitao, I think the tests are failing because of the code that already exists in main branch |
Thanks for the PR!! I will fix clippy. Meanwhile, it would be important to have some tests on this. Could you add them or would you like me to? |
@jorgecarleitao added some tests |
also closes #1263 |
BinaryArray::into_mut
and double-ended support for its iterator
Thanks a lot @ozgrakkurt , this is really good stuff. We just released 0.14.1 (https://github.com/jorgecarleitao/arrow2/releases/tag/v0.14.1) with this, in case you depend on this being available. |
@jorgecarleitao thanks! |
Copy pasted the implementation of
Utf8ValuesIter