Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added BinaryArray::into_mut and double-ended support for its iterator #1255

Merged
merged 5 commits into from
Sep 27, 2022
Merged

Conversation

ozgrakkurt
Copy link
Contributor

Copy pasted the implementation of Utf8ValuesIter

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 83.12% // Head: 83.12% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (bc759a1) compared to base (e972df0).
Patch coverage: 83.67% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1255      +/-   ##
==========================================
- Coverage   83.12%   83.12%   -0.01%     
==========================================
  Files         359      359              
  Lines       38087    38152      +65     
==========================================
+ Hits        31661    31715      +54     
- Misses       6426     6437      +11     
Impacted Files Coverage Δ
src/array/binary/mutable.rs 84.21% <0.00%> (-2.87%) ⬇️
src/io/parquet/write/binary/basic.rs 90.37% <ø> (-0.48%) ⬇️
src/array/binary/mod.rs 90.22% <90.62%> (+1.33%) ⬆️
src/array/binary/iterator.rs 97.22% <100.00%> (+16.26%) ⬆️
src/array/utf8/mod.rs 82.71% <0.00%> (-0.93%) ⬇️
src/io/ipc/read/schema.rs 95.58% <0.00%> (-0.30%) ⬇️
src/compute/sort/lex_sort.rs 75.80% <0.00%> (-0.20%) ⬇️
src/compute/arithmetics/decimal/div.rs 95.27% <0.00%> (-0.13%) ⬇️
src/compute/arithmetics/decimal/add.rs 96.59% <0.00%> (-0.12%) ⬇️
src/compute/arithmetics/decimal/sub.rs 96.73% <0.00%> (-0.11%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ozgrakkurt
Copy link
Contributor Author

Hey @jorgecarleitao, I think the tests are failing because of the code that already exists in main branch

@ozgrakkurt ozgrakkurt changed the title impl DoubleEndedIterator for BinaryValueIter add some missing code that exists for Utf8 but not for Binary Sep 23, 2022
@jorgecarleitao
Copy link
Owner

Thanks for the PR!!

I will fix clippy. Meanwhile, it would be important to have some tests on this. Could you add them or would you like me to?

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Sep 25, 2022
@ozgrakkurt
Copy link
Contributor Author

@jorgecarleitao added some tests

@ozgrakkurt
Copy link
Contributor Author

also closes #1263

@jorgecarleitao jorgecarleitao changed the title add some missing code that exists for Utf8 but not for Binary Added BinaryArray::into_mut and double-ended support for its iterator Sep 27, 2022
@jorgecarleitao jorgecarleitao merged commit 22f5568 into jorgecarleitao:main Sep 27, 2022
@jorgecarleitao
Copy link
Owner

Thanks a lot @ozgrakkurt , this is really good stuff. We just released 0.14.1 (https://github.com/jorgecarleitao/arrow2/releases/tag/v0.14.1) with this, in case you depend on this being available.

@ozgrakkurt
Copy link
Contributor Author

@jorgecarleitao thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants