This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 224
Added avro record names when converting arrow schema to avro #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR, thank you! 🙇
Left some minor comments but otherwise good to go!
Codecov ReportBase: 83.12% // Head: 83.14% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1279 +/- ##
==========================================
+ Coverage 83.12% 83.14% +0.01%
==========================================
Files 369 369
Lines 40180 40191 +11
==========================================
+ Hits 33399 33415 +16
+ Misses 6781 6776 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Samrose-Ahmed
force-pushed
the
main
branch
2 times, most recently
from
November 13, 2022 10:09
082974b
to
1982195
Compare
Could you rebase and run |
Thanks I've run clippy and fmt and updated. |
jorgecarleitao
changed the title
Add avro record names when converting arrow schema to avro
Added avro record names when converting arrow schema to avro
Nov 23, 2022
ritchie46
pushed a commit
to ritchie46/arrow2
that referenced
this pull request
Mar 29, 2023
…eitao#1279) add avro record names when converting arrow schema to avro
ritchie46
pushed a commit
to ritchie46/arrow2
that referenced
this pull request
Apr 5, 2023
…eitao#1279) add avro record names when converting arrow schema to avro
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes avro serialization by adding record names when converting Arrow schema to Avro schema.
Closes #1269