-
Notifications
You must be signed in to change notification settings - Fork 224
Conversation
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Codecov ReportBase: 83.09% // Head: 83.12% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1299 +/- ##
==========================================
+ Coverage 83.09% 83.12% +0.02%
==========================================
Files 369 369
Lines 40168 40180 +12
==========================================
+ Hits 33378 33398 +20
+ Misses 6790 6782 -8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Xuanwo <[email protected]>
Random thought: you may want to consider checking Cargo.lock into version control! Even though standard practice is to avoid checking in Cargo.lock for library crates, I've found it helpful in my library-only projects, as it ensures that new releases of dependencies can't break CI in my repository. |
Interesting idea! I will leave this for @jorgecarleitao to decide, although I prefer to break CI early. Checkout |
I also think it is beneficial to have the CI issues flagged sooner than later. |
Thanks a lot for the PR, @Xuanwo ! |
Signed-off-by: Xuanwo [email protected]