Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fix deprecated warning from chrono #1299

Merged
merged 4 commits into from
Nov 15, 2022

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Nov 13, 2022

Signed-off-by: Xuanwo [email protected]

Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Base: 83.09% // Head: 83.12% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (630de10) compared to base (c23d813).
Patch coverage: 96.42% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1299      +/-   ##
==========================================
+ Coverage   83.09%   83.12%   +0.02%     
==========================================
  Files         369      369              
  Lines       40168    40180      +12     
==========================================
+ Hits        33378    33398      +20     
+ Misses       6790     6782       -8     
Impacted Files Coverage Δ
src/array/list/mutable.rs 80.08% <ø> (ø)
src/io/odbc/read/deserialize.rs 0.00% <0.00%> (ø)
src/temporal_conversions.rs 90.22% <100.00%> (+0.46%) ⬆️
src/bitmap/immutable.rs 86.06% <0.00%> (-0.61%) ⬇️
src/io/ipc/read/schema.rs 95.88% <0.00%> (+0.29%) ⬆️
src/array/utf8/mod.rs 85.67% <0.00%> (+0.91%) ⬆️
src/array/binary/mod.rs 92.53% <0.00%> (+0.97%) ⬆️
src/bitmap/utils/slice_iterator.rs 98.78% <0.00%> (+1.21%) ⬆️
src/chunk.rs 92.85% <0.00%> (+2.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Xuanwo <[email protected]>
@benesch
Copy link
Contributor

benesch commented Nov 13, 2022

Random thought: you may want to consider checking Cargo.lock into version control! Even though standard practice is to avoid checking in Cargo.lock for library crates, I've found it helpful in my library-only projects, as it ensures that new releases of dependencies can't break CI in my repository.

@Xuanwo
Copy link
Contributor Author

Xuanwo commented Nov 14, 2022

it ensures that new releases of dependencies can't break CI in my repository.

Interesting idea!

I will leave this for @jorgecarleitao to decide, although I prefer to break CI early. Checkout Cargo.lock in the repo will not change the fact that we need to resolve the deprecate warnings by hand, it only changes the time of finding them.

@jorgecarleitao
Copy link
Owner

I also think it is beneficial to have the CI issues flagged sooner than later.

@jorgecarleitao jorgecarleitao merged commit 0ba4f8e into jorgecarleitao:main Nov 15, 2022
@jorgecarleitao
Copy link
Owner

Thanks a lot for the PR, @Xuanwo !

ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Mar 29, 2023
ritchie46 pushed a commit to ritchie46/arrow2 that referenced this pull request Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants